[BUGFIX + ENHANCEMENT] Use SongNoteData for pico-speaker and otis-speaker animations
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Contributor
|
Fixes FunkinCrew/Funkin#5115 |
AbnormalPoof
force-pushed
the
develop
branch
5 times, most recently
from
e0ba6ab to
bcd30e1
Compare
Hundrec
added
status: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes FunkinCrew/Funkin#5115
Description
Usually,
pico-speakerandotis-speakerqueue animations by having two seperate arrays for timing and direction. This PR changes this by directly using theSongNoteDataclass, which completely eliminates the need for two arrays.This PR also fixes any inconsistencies caused by resetting the song.
Screenshots/Videos